From c50659c29955f0fef0e0551eb720adcd279c6235 Mon Sep 17 00:00:00 2001
From: Casual <c@sual.in>
Date: Thu, 11 Apr 2024 01:40:10 +0300
Subject: [PATCH] RAM consumption fix

---
 main.go    | 22 +++++++++++-----------
 options.go |  4 ++--
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/main.go b/main.go
index e7a1e3c..163b172 100644
--- a/main.go
+++ b/main.go
@@ -12,6 +12,7 @@ import (
 	"crypto/tls"
 	"bufio"
 	"sync"
+	// "runtime"
 	// "encoding/json"
 	// "iouti"
 )
@@ -187,6 +188,7 @@ func main() {
 			fmt.Println("User -",user)
 		
 			options.bruteforce(user)
+			// runtime.GC() //TODO might a hack to free memory, need to learn more where it's allocated. My guess it's channel. P.S. Yep, it is
 		
 		}
 	} else {
@@ -204,18 +206,16 @@ func (options Options) bruteforce(user string) {
 		passwords := bufio.NewScanner(passFile)
 		passwords.Split(bufio.ScanLines)
 
-		pass := make(chan string, 1000000000) // rockyou - 14344391
+		// pass := make(chan string, 15000001) // rockyou - 14,344,391
+		pass := make(chan string, 1000) // primarly we need big enough buffer to prevent slowdown for workers, so we kinda expect less then 1000 workers/threads 
 
-		for passwords.Scan() {
-			// fmt.Println("add pass - ",passwords.Text())
-			pass <- string(passwords.Text())
-			// fmt.Println("ASDASDAS")
-		} //TODO ERROR
-		close(pass)
-
-							// fmt.Println("ASDASDAS")
-
-					// fmt.Println(pass)
+		go func() {
+			for passwords.Scan() { //TODO BUG constantly rereads file to write it to channel. Better way would be to write it in string/[]string var and then from it write to channel. Doubles memory but we don't rely on reading file from HDD which might be busy slowing down burteforce
+				pass <- string(passwords.Text())
+			} 
+			close(pass)
+		}()
+		
 		var foundPass = false
 		// for _ := range options.Threads {
 		for i:=0; i<options.Threads && ! foundPass; i++  {
diff --git a/options.go b/options.go
index 8079717..e12febc 100644
--- a/options.go
+++ b/options.go
@@ -19,7 +19,7 @@ type Options struct {
 	PassFile	string
 	// Pass  	string //password spray TODO
 	Proxy	string
-	Verbose   bool
+	// Verbose   bool
 }
 
 
@@ -43,7 +43,7 @@ func ParseOptions() (*Options,error) {
 			flagSet.StringVarP(&options.User, "l", "login", "admin", "username to bruteforce"),
 			flagSet.StringVarP(&options.UserFile, "L", "login-wordlist", "", "username wordlist"),
 			flagSet.StringVarP(&options.PassFile, "P", "password-wordlist", "", "Password wordlist"),
-			flagSet.StringVarP(&options.Proxy, "x", "proxy", "", "HTTP proxy for packet inspection (Burp/Caidu/ZAP) (for example http://127.0.0.1:8080). But be aware, if you enable inspection then attack will fail because of delays"),
+			flagSet.StringVarP(&options.Proxy, "x", "proxy", "", "HTTP proxy for packet inspection (Burp/Caidu/ZAP) (for example http://127.0.0.1:8080). But be aware, if you enable inspection then attack will fail because of delays. Also expect bigger CPU usage, use for testing"),
 			flagSet.IntVarP(&options.Threads, "t", "threads", 10, "threads to bruteforce"), //TODO add estimate counter to packets/s
 			// flagSet.StringVarP(&options.URL, "u", "url", "", "target's url to login page. Example \"https://example.com/index.php/login, http://example.com/login \""),
 		)